To provide a shock absorber by which a DC current can be fed and which is provided with a function for feeding power between the upper part of a spring and the lower part of the spring.

The twin-tube type shock absorber, whose inner cylinder 10 is constituted of a conductive metal, is composed so as to be connected to a harness 4b extended to the side of the lower part of the spring from a drawing-out hole 31. A piston rod 20 has a rebound stopper 23, a brush holder 2 under the rebound stopper 23, and an electrode plate member 8 on the outer peripheral face above the brush holder. The brush holder has a brush chamber 2a and stores the spring 3 and a brush 1, which is energized radially outwardly by the spring 3 and slides with the inner peripheral face of the inner cylinder, in the brush chamber 2a. The harness 4a connected to the brush reaches the upper end of the piston rod via a hole 32 and a center hole 21. The end cap has a hollow brush holder part 6 opening to a through-hole 24. A spring and a brush 5, which is energized radially inwardly by the spring and slides with the electrode plate member, are stored in the brush holder part 6. A harness 7a is connected to the electrode plate member and extended to the side of the upper part of the spring. A harness 7b is connected to the brush 5 and extended to the side of the lower part of the spring.