To provide a strut type shock absorber equipped with a structure capable of facilitating work for disposing and fixing a knuckle member between clipping pieces of a knuckle bracket in a short time.

In an outer tube 3 attached with the knuckle bracket 1 coupled with a knuckle arm 30 on an axle side, an inverted damper 5 having an attaching portion coupled to a vehicle body side is inserted to freely appear and disappear. The tip of a piston rod 6 inserted in the damper to freely appear and disappear is coupled to a lower portion 7 of the outer tube 3. The knuckle bracket 1 is composed of a pair of the clipping pieces 20a, 20b clipping the knuckle arm 30. Attaching holes 21a, 21b for attaching the knuckle arm 30 are formed on the clipping pieces 20a, 20b. In the strut type shock absorber, a rib 32 positioning the knuckle arm 30 to the clipping pieces 20a, 20b when the knuckle arm 30 is disposed between the clipping pieces 20a, 20b is provided on the pair of the clipping pieces 10a, 20b.