To provide a strut type shock absorber wherein not only the mounting strength of a knuckle bracket to an outer shell can be freely set but also the knuckle bracket can be welded and fixed to the outer shell securely by efficient work without considering dripping of molten metal and welding condition at the time of welding.

The strut type shock absorber 1 provided with the outer shell 2 and the knuckle bracket 3 welded and fixed to a lower part of the outer shell 2 and the knuckle bracket 3 consists of a bracket main body 4 of an approximate cylinder shape for holding the outer shell 2 and a pair of pinching parts 5 for mounting the pair of knuckle arms protruding from the bracket main body 4 in a cross direction. An open window 11 facing the outer shell 2 is provided in the bracket main body 4 and a boundary part of a circumference edge of the open window 11 and an outer circumference surface of the outer shell 2 is welded Y.